Repository navigation
PYTHON-6247 Enable ruff ISC rules - #3207
Merged
Merged
Conversation
NoahStapp
requested review from
sleepyStick
and
a balanced review from Copilot
November 11, 2026 18:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the change enabling Ruff’s implicit string concatenation checks.
No open issues 🎉
What changed in this PR
Enables Ruff’s implicit string concatenation (ISC) rules in PyMongo’s lint configuration. No application code changes are included.
Changes:
- Removes
ISCfrom Ruff’s ignored rule groups.
| File | Description |
|---|---|
pyproject.toml |
Enables checks for implicit string concatenation by removing the ISC exclusion. |
Review effort: Balanced
sleepyStick
previously approved these changes
Nov 11, 2026
sleepyStick
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6247
Changes in this PR
Enable ruff's
ISClinting rules. No changes are required to pass the checks.Test Plan
Checklist
Checklist for Author
Checklist for Reviewer